fix(antares): use local fuse layer for metadata writes - #10
fix(antares): use local fuse layer for metadata writes#10Ivanbeethoven wants to merge 9 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbeb71ea7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| futures = "0.3.31" | ||
| uuid = { version = "1.20.0", features = ["v4"] } | ||
| libfuse-fs = { version = "0.1.13"} | ||
| libfuse-fs = { path = "../rk8s/project/libfuse-fs" } |
There was a problem hiding this comment.
With this path-only dependency, a normal checkout no longer builds unless the user has cloned rk8s at exactly ../rk8s; I ran cargo check --all-targets from /workspace/scorpiofs and Cargo failed trying to read /workspace/rk8s/project/libfuse-fs/Cargo.toml. The workflow changes add that sibling only in GitHub Actions, so local developers, cargo install --git, and crates.io/docs.rs consumers cannot resolve the package. Please keep a registry/git dependency or make the local override optional outside CI.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4424423a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| futures = "0.3.31" | ||
| uuid = { version = "1.20.0", features = ["v4"] } | ||
| libfuse-fs = { version = "0.1.13"} | ||
| libfuse-fs = { git = "https://github.com/rk8s-dev/rk8s.git", branch = "codex/stabilize-libfuse-buck2-races" } |
There was a problem hiding this comment.
Fresh evidence versus the earlier path-dependency issue is that the current manifest now uses git-only dependencies: this libfuse-fs line, and the matching rfuse3 git dependency above. Because this crate is advertised on crates.io/docs.rs, the next release will be blocked: Cargo's dependency docs note that crates.io does not allow published packages to depend on code outside crates.io except dev-dependencies, and recommend adding a registry version fallback for git/path overrides (https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations).
Useful? React with 👍 / 👎.
2 participants
Summary
Validation